Skip to content

[UR][Offload] Use new olMemInfo systems #20015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from
Open

[UR][Offload] Use new olMemInfo systems #20015

wants to merge 2 commits into from

Conversation

RossBrunton
Copy link
Contributor

We no longer track allocations, and olMemInfo is implemented fully.

@RossBrunton RossBrunton marked this pull request as ready for review September 24, 2025 11:21
@RossBrunton RossBrunton requested a review from a team as a code owner September 24, 2025 11:21
@RossBrunton
Copy link
Contributor Author

@intel/unified-runtime-reviewers @pbalcer Can I get this looked at when you get the chance?

pbalcer
pbalcer approved these changes Sep 25, 2025
View reviewed changes
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one nit.

@github-actions GitHub Actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

RossBrunton and others added 2 commits September 25, 2025 15:29
@RossBrunton
[UR][Offload] Use new olMemInfo systems
cc40f7a 
We no longer track allocations, and `urMemGetInfo` is implemented fully.
@RossBrunton
Remove unreachable return
fed03f8
@github-actions GitHub Actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

@intel/llvm-gatekeepers please consider merging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

@intel/llvm-gatekeepers please consider merging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

@intel/llvm-gatekeepers please consider merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbalcer pbalcer pbalcer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RossBrunton @pbalcer